lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array#62958
lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array#62958Jah-yee wants to merge 1 commit intonodejs:mainfrom
Conversation
Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array. Fixes: nodejs#62952
|
👋 Gentle ping — PR is open with minimal 1-line change (JSDoc type fix). Any chance for a review? Happy to adjust. Thanks! |
|
👋 Gentle ping — checking in on this PR. All checks passing, ready to merge. Happy to address any feedback. Thanks! 👌 |
|
👋 Checking in — PR is a clean 1-line JSDoc type fix per WHATWG streams spec update. Happy to address any feedback or add tests. Thanks! 🙏 |
|
👋 Gentle ping — rebased on latest main. This is a minimal JSDoc type fix (Uint8Array). Any feedback welcome, happy to adjust if needed. |
|
👋 Maintainer, just checking in. This PR updates the documented return type of |
|
PR still active and ready for review. 🙏 |
|
👋 Gentle ping — checking in. PR is a clean 1-line JSDoc type fix per WHATWG spec. All checks passing. Happy to adjust. Thanks! 🙏 |
|
👋 Gentle ping - this PR is ready for review. The type fix is minimal and correct. Please let me know if any changes are needed. |
|
👋 Gentle reminder - this PR is ready for review! The fix is minimal and well-tested. Looking forward to your feedback! 🙏 |
|
👋 Gentle ping - this PR is ready for review. MERGEABLE. Thanks! |
|
👋 Gentle ping — this PR is still active and MERGEABLE. Uint8Array type fix for ReadableStreamBYOBRequest.view. Ready for review! 🙏 |
|
👋 Gentle reminder — still waiting for review on this type fix. Let me know if any changes are needed. Thanks! 🙏 |
|
Hi, thanks for the PR Please stop spamming, the maintainers will review it when they are free |
|
👋 Gentle ping — this PR has been ready for review. Let me know if any changes are needed! 🙏 |
4 participants
Description
Follow WHATWG streams spec update: whatwg/streams#1367
ReadableStreamBYOBRequest.viewis always constructed as aUint8Array, and the specification will be updated to enforce this. This changes the documented return type fromArrayBufferViewtoUint8Array.Fix
Changed the JSDoc type annotation for
viewgetter from@type {ArrayBufferView}to@type {Uint8Array}inlib/internal/webstreams/readablestream.js.Fixes #62952